Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

AP_HAL_ChibiOS: remove setting HAL_USE_UART to false #29016

Merged
merged 1 commit into from
Jan 15, 2025
Merged

AP_HAL_ChibiOS: remove setting HAL_USE_UART to false #29016

merged 1 commit into from
Jan 15, 2025

Conversation

peterbarker
Copy link
Contributor

@peterbarker peterbarker commented Jan 6, 2025 •
edited
Loading

this is the default

Board           AP_Periph  bootloader
Here4AP         *          *
Hitec-Airspeed  *          *
HitecMosaic     *          *
f103-GPS        *          *
f303-GPS        *          *
f303-MatekGPS   *          *

(adjusted results to include bootloader results)

@tpwrules
Copy link
Contributor

tpwrules commented Jan 6, 2025 •
edited
Loading

Assuming this is good if CI passes. Always like less lines.

Worth attacking the other related looking ones in the same PR?

  • empty SERIAL_ORDER
  • define HAL_NO_UARTDRIVER TRUE
  • define HAL_USE_SERIAL FALSE

@peterbarker
Copy link
Contributor Author

Assuming this is good if CI passes. Always like less lines.

Worth attacking the other related looking ones in the same PR?

* empty `SERIAL_ORDER`

* `define HAL_NO_UARTDRIVER TRUE`

* `define HAL_USE_SERIAL FALSE`

Yes, they're worth looking at. The first is likely to be a script problem, just a little but of python work.

I'm working on the second (https://github.com/peterbarker/ardupilot/tree/pr/HAL_NO_UARTDRIVER-usage)

Had a glance at the third earlier today and scratched my head a little...

@peterbarker peterbarker force-pushed the pr/hal-chibios-remove-HAL_USE_UART-FALSE branch from 19bbc39 to 5239517 Compare January 14, 2025 01:29
@peterbarker peterbarker force-pushed the pr/hal-chibios-remove-HAL_USE_UART-FALSE branch from 5239517 to b91782b Compare January 14, 2025 06:26
MattKear
MattKear approved these changes Jan 15, 2025
View reviewed changes
Copy link
Contributor

@MattKear MattKear left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@peterbarker peterbarker merged commit 6b63d3a into ArduPilot:master Jan 15, 2025
44 checks passed
@peterbarker peterbarker deleted the pr/hal-chibios-remove-HAL_USE_UART-FALSE branch January 15, 2025 21:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MattKear MattKear MattKear approved these changes

@Georacer Georacer Georacer approved these changes

Assignees
No one assigned
Labels
DevCallEU
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@peterbarker @tpwrules @Georacer @MattKear